[Clfs-dev] Buglet on CLFS-EMBEDDED-GIT-0.0.1-20110514 book

[Andrew Bradford]

On Wednesday 22 August 2012 10:32:24 Ron McDowell wrote:
> On 8/22/12 6:09 AM, Andrew Bradford wrote:
> > On Tuesday 21 August 2012 19:24:11 William Harrington wrote:
> >> On Aug 21, 2012, at 09:44 AM, Andrew Bradford wrote:
> >>> On Saturday 18 August 2012 10:58:36 Ron McDowell wrote:
> >>>> In CLFS-EMBEDDED-GIT-0.0.1-20110514/arm/beyond-net/dropbear.html
> >>>> 
> >>>> 
> >>>> Last line of 14.4.1 reads
> >>>> 
> >>>>       make install-sshd DESTDIR=${CLFS}
> >>>> 
> >>>> The above does not work for me.  The below does, though.
> >>>> 
> >>>>       make install-dropbear DESTDIR=${CLFS}
> >>> 
> >>> I believe `make install-sshd` is correct.  It's the words before
> >>> that which are confusing and should be fixed.
> >>> 
> >>> You're supposed to execute that `make` command from within the
> >>> bootscripts directory (either extracted tarball or from a git
> >>> pull [1]).
> >>> Don't execute it in the dropbear sources.  You're installing the
> >>> CLFS bootscript for sshd (which is dropbear).
> >>> 
> >>> [1]:http://git.cross-lfs.org/?p=bootscripts-embedded.git;a=summar
> >>> y
> >>> 
> >>> Does that make sense?
> >>> If so, how can we make the wording better in 14.4.1?
> >> 
> >> Been looking through it and it looks okay to me. Each time in the
> >> beyond net section, if bootscripts are to be installed, the
> >> instructions state to install the bootscripts from the clfs boot
> >> scripts package.
> > 
> > Valid point.  But maybe each time the bootscripts are to be
> > installed we could make it more clear?  Like having another
> > sub-sub-section?
> > 
> >> And here: http://cross-lfs.org/view/clfs-embedded/x86/bootscripts/
> >> bootscripts.html  states to keep the clfs bootscripts package
> >> extracted as it may need to be used later....
> >> 
> >> Not sure how we can make it clearer. We won't add a separate
> >> command to extract the clfs bootscripts again, the text before
> >> the command clearly state that the command to be executed deals
> >> with the clfs bootscripts.
> > 
> > Could, for example with dropbear, we have the last part, where
> > bootscripts are installed, be section 14.4.2 and then Contents be
> > 14.4.3?
> > 
> > Then at least we'd have a heading, maybe make the heading "Install
> > dropbear bootscripts" and give a quick one-liner saying "Change to
> > the bootscripts directory and install the sshd bootscript:"
> > 
> > Like this patch (from current embedded master):
> > > From b3e0f5b2d04d8facba868118d6c55bf29b650107 Mon Sep 17 00:00:00
> > > 2001
> > 
> > From: Andrew Bradford<andrew.bradford at omni-id.com>
> > Date: Wed, 22 Aug 2012 07:06:18 -0400
> > Subject: [PATCH] dropbear: Easier to see what to use for
> > bootscripts
> > 
> > Signed-off-by: Andrew Bradford<andrew.bradford at omni-id.com>
> > ---
> > 
> >   BOOK/beyond-net/common/dropbear.xml |    9 ++++++++-
> >   1 file changed, 8 insertions(+), 1 deletion(-)
> > 
> > diff --git a/BOOK/beyond-net/common/dropbear.xml
> > b/BOOK/beyond-net/common/dropbear.xml index e797cd7..66bbed5
> > 100644
> > --- a/BOOK/beyond-net/common/dropbear.xml
> > +++ b/BOOK/beyond-net/common/dropbear.xml
> > @@ -66,7 +66,14 @@ ln -svf /usr/bin/dropbearmulti
> > ${CLFS}/usr/bin/scp</userinput></screen>
> > 
> >   <screen os="k"><userinput>install -dv
> >   ${CLFS}/etc/dropbear</userinput></screen>
> > 
> > -<para os="l">Install the bootscripts from the clfs-bootscripts
> > package:</para> +
> > +</sect2>
> > +
> > +<sect2 role="bootscripts">
> > +<title>Installation of Dropbear Bootscripts</title>
> > +
> > +<para os="l"> From the clfs-bootscripts package, install the
> > Dropbear +            bootscripts:</para>
> > 
> >   <screen os="m"><userinput>make install-sshd
> >   DESTDIR=${CLFS}</userinput></screen>
> 
> Sorry, been on the road last few days.  My
> clfs-embedded-bootscripts-1.0-pre5/Makefile flat out does not contain
> "install-sshd", and does contain "install-dropbear":
> 
> [rcm at samsung550(Linux)]> grep "^install"
> clfs-embedded-bootscripts-1.0-pre5/Makefile
> install-bootscripts: create-dirs
> install-bcm47xx: create-dirs
> install-dropbear: create-dirs
> install-hostapd: create-dirs
> 
> If the book is right, then the Makefile needs to be fixed. :)  Unless
> I've got the wrong bootscripts tarball...this is to build CLFS armv4t
> for a FriendlyARM Mini2440.

<facepalm/>

Yes, you're right.
Patch below.

-Andrew

Signed-off-by: Andrew Bradford <andrew at bradfordembedded.com>
---
 BOOK/beyond-net/common/dropbear.xml |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/BOOK/beyond-net/common/dropbear.xml b/BOOK/beyond-net/common/dropbear.xml
index e797cd7..6a4ec32 100644
--- a/BOOK/beyond-net/common/dropbear.xml
+++ b/BOOK/beyond-net/common/dropbear.xml
@@ -68,7 +68,7 @@ ln -svf /usr/bin/dropbearmulti ${CLFS}/usr/bin/scp</userinput></screen>
 
     <para os="l">Install the bootscripts from the clfs-bootscripts package:</para>
 
-<screen os="m"><userinput>make install-sshd DESTDIR=${CLFS}</userinput></screen>
+<screen os="m"><userinput>make install-dropbear DESTDIR=${CLFS}</userinput></screen>
 
 
   </sect2>
-- 
1.7.10