[Clfs-commits] [Cross-LFS]Cross-LFS Book branch, sysvinit, updated. clfs-3.0.0-sysvinit-296-g4624334

[akhiezer]

> Date: Sat, 22 Apr 2017 01:45:05 +0000 (UTC)
> Subject: [Clfs-commits] [Cross-LFS]Cross-LFS Book branch, sysvinit,
> 	updated. clfs-3.0.0-sysvinit-296-g4624334
>
	.
	.
> diff --git a/BOOK/final-system/multilib/ncurses-64bit.xml b/BOOK/final-system/multilib/ncurses-64bit.xml
> index ad4bf20..b71fd8b 100644
> --- a/BOOK/final-system/multilib/ncurses-64bit.xml
> +++ b/BOOK/final-system/multilib/ncurses-64bit.xml
> @@ -35,8 +35,8 @@
>      href="ncurses.xml"
>      xpointer="xpointer(//*[@os='a'])"/>
>  
> -<screen os="b"><userinput>CC="gcc ${BUILD64}" CXX="g++ ${BUILD64}" \
> -./configure \
> +<screen os="b"><userinput>PKG_CONFIG_PATH=${PKG_CONFIG_PATH64} \
> +CC="gcc ${BUILD64}" CXX="g++ ${BUILD64}" ./configure \
>      --prefix=/usr \
>      --libdir=/usr/lib64 \
>      --with-shared \
> diff --git a/BOOK/final-system/multilib/ncurses-n32.xml b/BOOK/final-system/multilib/ncurses-n32.xml
> index e109f3d..cd12181 100644
> --- a/BOOK/final-system/multilib/ncurses-n32.xml
> +++ b/BOOK/final-system/multilib/ncurses-n32.xml
> @@ -36,8 +36,8 @@
>      href="ncurses.xml"
>      xpointer="xpointer(//*[@os='a'])"/>
>  
> -<screen os="b"><userinput>CC="gcc ${BUILDN32}" CXX="g++ ${BUILDN32}" \
> -./configure \
> +<screen os="b"><userinput>PKG_CONFIG_PATH=${PKG_CONFIG_PATHN32} \
> +CC="gcc ${BUILDN32}" CXX="g++ ${BUILDN32}" ./configure \
>      --prefix=/usr \
>      --libdir=/usr/lib32 \
>      --with-shared \
>


Instead of having the individual variables:

  PKG_CONFIG_PATHN32
  PKG_CONFIG_PATH64
  BUILDN32
  BUILD64

; it's perhaps better to use the more-generic variables:

  PKG_CONFIG_PATH
  BUILD	# or another name.

; and define their values centrally according to one/more core/central
variables whose values are N32 or 64 &c.


That way, the above 'PKG_CONFIG_PATH=... CC=... CCX=... ./configure '
strings can be the same across books.


That approach also scales better and can be less error-prone.



akh





--